Sign in to inline

Continue to your review console.

Checksacme/payments-api#4127

build

Build and type check

42s

test

Unit tests

1m 12s

inline / review

2 unresolved findings block this merge

1m 47s

Merging is blockedblock on high

Idempotency key is written after the chargethread resolved
Replay cache key omits the tenant idcode changed by 8f4c1ab
Retry budget is never reset between attemptsawaiting a reply

inlinebotcharges.ts:118

highconcurrencyconf 94%

Idempotency key is written after the charge, not before

Two requests carrying the same key can both pass the existence check before either row lands, so the customer is charged twice. Insert the key first and treat the unique-violation as the replay path.

116const existing = await keys.find(key);

117- const charge = await stripe.charge(amount);

117+ await keys.insert(key); // unique index

fixedresolved by a later push